Messages in this thread | ![/](/images/icornerl.gif) | | Date | Mon, 1 Apr 2024 14:50:29 +0500 | Subject | Re: [PATCH] selftests/mm: import strings.h for ffsl | From | Muhammad Usama Anjum <> |
| |
On 3/30/24 1:33 AM, Edward Liaw wrote: > On Fri, Mar 29, 2024 at 12:32 PM Muhammad Usama Anjum > <usama.anjum@collabora.com> wrote: >> >> On 3/29/24 10:42 PM, Edward Liaw wrote: >>> Got a compilation error for ffsl after 91b80cc5b39f ("selftests: mm: fix >>> map_hugetlb failure on 64K page size systems") imported vm_util.h. >>> >>> Fixes: af605d26a8f2 ("selftests/mm: merge util.h into vm_util.h") >> Why do you think this Fixes tag is needed? This refers to a patch which is >> just moving code. It doesn't seem to have any thing related to strings.h. > Oops, I guess it should be: > > Fixes: 6f6a841fb77d ("selftest/vm: add helpers to detect PAGE_SIZE and > PAGE_SHIFT") LGTM
>
-- BR, Muhammad Usama Anjum
| ![\](/images/icornerr.gif) |