Messages in this thread Patch in this message | ![/](/images/icornerl.gif) | | From | Kwangjin Ko <> | Subject | [PATCH 2/2] cxl/core: Fix incorrect array index in cxl_clear_event_record() | Date | Mon, 1 Apr 2024 18:10:56 +0900 |
| |
The variable 'i' should be incremented after dev_dbg(), or print gen->hdr.handle instead. Otherwise, the handle value of the next loop will be printed. Furthermore, in the final loop, accessing 'handles[i]' will cause a buffer overflow.
Signed-off-by: Kwangjin Ko <kwangjin.ko@sk.com> --- drivers/cxl/core/mbox.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/cxl/core/mbox.c b/drivers/cxl/core/mbox.c index a38531a055c8..84014aa01c95 100644 --- a/drivers/cxl/core/mbox.c +++ b/drivers/cxl/core/mbox.c @@ -913,9 +913,9 @@ static int cxl_clear_event_record(struct cxl_memdev_state *mds, struct cxl_event_record_raw *raw = &get_pl->records[cnt]; struct cxl_event_generic *gen = &raw->event.generic; - payload->handles[i++] = gen->hdr.handle; dev_dbg(mds->cxlds.dev, "Event log '%d': Clearing %u\n", log, - le16_to_cpu(payload->handles[i])); + le16_to_cpu(gen->hdr.handle)); + payload->handles[i++] = gen->hdr.handle; if (i == max_handles) { payload->nr_recs = i; -- 2.34.1
| ![\](/images/icornerr.gif) |