Messages in this thread | | | Date | Mon, 1 Apr 2024 15:23:04 +0800 | Subject | Re: [PATCH v19 039/130] KVM: TDX: initialize VM with TDX specific parameters | From | Xiaoyao Li <> |
| |
On 3/29/2024 2:26 AM, Edgecombe, Rick P wrote: > On Thu, 2024-03-28 at 09:36 +0800, Xiaoyao Li wrote: >>>>> Any reason to mask off non-configurable bits rather than return an error? this >>>>> is misleading to userspace because guest sees the values emulated by TDX module >>>>> instead of the values passed from userspace (i.e., the request from userspace >>>>> isn't done but there is no indication of that to userspace). >>>> >>>> Ok, I'll eliminate them. If user space passes wrong cpuids, TDX module will >>>> return error. I'll leave the error check to the TDX module. >>> >>> I was just looking at this. Agreed. It breaks the selftests though. >> >> If all you prefer to go this direction, then please update the error >> handling of this specific SEAMCALL. > > What do you mean by SEAMCALL, TDH_MNG_INIT? Can you be more specific?
Sorry. I missed the fact that current patch already has the specific handling for TDX_OPERAND_INVALID for TDH.MNG.INIT.
I need to update QEMU to match the new behavior.
| |