Messages in this thread | | | Date | Sat, 30 Mar 2024 12:36:27 +0100 | Subject | Re: [PATCH 4/5] driver: spi: cadence: Add ACPI support | From | Krzysztof Kozlowski <> |
| |
On 29/03/2024 20:48, Witold Sadowski wrote: > From: Piyush Malgujar <pmalgujar@marvell.com> > > These changes enables to read the configs from ACPI tables as > required for successful probing in ACPI uefi environment. > In case of ACPI disabled/dts based environment, it will continue to > read configs from dts as before. >
Random subjects... Please use subject prefixes matching the subsystem. You can get them for example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory your patch is touching.
> } > > +static const struct acpi_device_id cdns_xspi_acpi_match[] = { > + {"cdns,xspi-nor", 0}, > + {"mrvl,xspi-nor", 0},
How is this ACPI?
> + {}, > +}; > +MODULE_DEVICE_TABLE(acpi, cdns_xspi_acpi_match); > +#ifdef CONFIG_OF
This was never compiled. I could understand not testing bindings, because it is something relatively new - like 5 or 6 years. But not compiling code is less understandable.
Best regards, Krzysztof
| |