Messages in this thread | | | From | Linus Walleij <> | Date | Tue, 27 Feb 2024 10:41:21 +0100 | Subject | Re: [rfc, PATCH v1 1/1] gpiolib: Get rid of never false gpio_is_valid() calls |
| |
On Wed, Feb 21, 2024 at 10:32 PM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> In the cases when gpio_is_valid() is called with unsigned parameter > the result is always true in the GPIO library code, hence the check > for false won't ever be true. Get rid of such calls. > > While at it, move GPIO device base to be unsigned to clearly show > it won't ever be negative. This requires a new definition for the > maximum GPIO number in the system. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Looks right to me: Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
I guess it's related to the patch where we dropped <asm/gpio.h> and ARCH_NR_GPIOS because after that a lot if the semantics were removed from this function, but it's not quite a fix more of a cleanup.
Yours, Linus Walleij
| |