Messages in this thread | ![/](/images/icornerl.gif) | | Date | Tue, 9 Jan 2024 14:05:25 +0800 | Subject | Re: [PATCH] neighbour: purge nf_bridged skb from foreign device neigh | From | Pavel Tikhomirov <> |
| |
That problem happens because the patch is not ready to handle the lack of CONFIG_BRIDGE_NETFILTER (as Eric already mentioned earlier in this thread).
On 09/01/2024 13:38, kernel test robot wrote: > Hi Pavel, > > kernel test robot noticed the following build warnings: > > [auto build test WARNING on net-next/main] > [also build test WARNING on net/main linus/master horms-ipvs/master v6.7 next-20240108] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch#_base_tree_information] > > url: https://github.com/intel-lab-lkp/linux/commits/Pavel-Tikhomirov/neighbour-purge-nf_bridged-skb-from-foreign-device-neigh/20240108-165551 > base: net-next/main > patch link: https://lore.kernel.org/r/20240108085232.95437-1-ptikhomirov%40virtuozzo.com > patch subject: [PATCH] neighbour: purge nf_bridged skb from foreign device neigh > config: x86_64-defconfig (https://download.01.org/0day-ci/archive/20240109/202401091351.CqYRoau7-lkp@intel.com/config) > compiler: gcc-11 (Debian 11.3.0-12) 11.3.0 > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240109/202401091351.CqYRoau7-lkp@intel.com/reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot <lkp@intel.com> > | Closes: https://lore.kernel.org/oe-kbuild-all/202401091351.CqYRoau7-lkp@intel.com/ > > All warnings (new ones prefixed by >>): > > net/core/neighbour.c: In function 'neigh_purge_nf_bridge_dev': > net/core/neighbour.c:392:29: error: implicit declaration of function 'nf_bridge_info_get' [-Werror=implicit-function-declaration] > 392 | nf_bridge = nf_bridge_info_get(skb); > | ^~~~~~~~~~~~~~~~~~ >>> net/core/neighbour.c:392:27: warning: assignment to 'struct nf_bridge_info *' from 'int' makes pointer from integer without a cast [-Wint-conversion] > 392 | nf_bridge = nf_bridge_info_get(skb); > | ^ > net/core/neighbour.c:395:43: error: invalid use of undefined type 'struct nf_bridge_info' > 395 | if (nf_bridge && nf_bridge->physindev == dev) { > | ^~ > cc1: some warnings being treated as errors > > > vim +392 net/core/neighbour.c > > 382 > 383 static void neigh_purge_nf_bridge_dev(struct neighbour *neigh, struct net_device *dev) > 384 { > 385 struct sk_buff_head *list = &neigh->arp_queue; > 386 struct nf_bridge_info *nf_bridge; > 387 struct sk_buff *skb, *next; > 388 > 389 write_lock(&neigh->lock); > 390 skb = skb_peek(list); > 391 while (skb) { > > 392 nf_bridge = nf_bridge_info_get(skb); > 393 > 394 next = skb_peek_next(skb, list); > 395 if (nf_bridge && nf_bridge->physindev == dev) { > 396 __skb_unlink(skb, list); > 397 neigh->arp_queue_len_bytes -= skb->truesize; > 398 kfree_skb(skb); > 399 } > 400 skb = next; > 401 } > 402 write_unlock(&neigh->lock); > 403 } > 404 >
-- Best regards, Tikhomirov Pavel Senior Software Developer, Virtuozzo.
| ![\](/images/icornerr.gif) |