Messages in this thread | | | Date | Tue, 9 Jan 2024 12:20:53 -0800 | From | Josh Poimboeuf <> | Subject | Re: [PATCH v2 1/3] objtool: Make objtool check actually fatal upon fatal errors |
| |
On Tue, Jan 09, 2024 at 07:48:30PM +0000, Dimitri John Ledkov wrote: > > Note the latter may be problematic at the moment due to some outstanding > > warnings reported by Arnd and randconfig build bots. I try to fix those > > when I can, but any help would be appreciated. > > I guess we can override CONFIG_WERROR during dkms compilations, but > then i still want to ensofrce OBJTOOL errors. > > How abou introducing CONFIG_WERROR_OBJTOOL and make CONFIG_WERROR > select CONFIG_WERROR_OBJTOOL? such that distributions can start to opt > into CONFIG_WERROR_OBJTOOL for production builds, even if they cannot > yet make the jump to CONFIG_WERROR?
Seems reasonable.
Though, keep in mind that even compiler warnings can cause boot failures and security bugs. So I wouldn't recommend sleeping at night unless your distro also has CONFIG_WERROR=y.
-- Josh
| |