Messages in this thread | | | From | Jernej Škrabec <> | Subject | Re: [PATCH 10/12] mailbox: sun6i-msgbox: Convert to platform remove callback returning void | Date | Tue, 09 Jan 2024 21:15:52 +0100 |
| |
Dne sreda, 27. december 2023 ob 22:02:38 CET je Uwe Kleine-König napisal(a): > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is ignored (apart > from emitting a warning) and this typically results in resource leaks. > > To improve here there is a quest to make the remove callback return > void. In the first step of this quest all drivers are converted to > .remove_new(), which already returns void. Eventually after all drivers > are converted, .remove_new() will be renamed to .remove(). > > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Best regards, Jernej
| |