Messages in this thread | ![/](/images/icornerl.gif) | | Date | Tue, 9 Jan 2024 12:31:53 -0700 | Subject | Re: [PATCH RESEND v4 1/3] kselftests: lib.mk: Add TEST_GEN_MODS_DIR variable | From | Shuah Khan <> |
| |
On 1/8/24 10:13, Marcos Paulo de Souza wrote: > On Wed, 2024-01-03 at 15:09 -0700, Shuah Khan wrote:
>> >> Copying source files and object files doesn't sound right. This isn't >> how the ksleftest installs work. Let's fix this. > > Hi Shuah, > > what do you think about the proposed solution? Could you please amend > the fix into the first patch if you think it's the right approach? >
I would like to see a new revision of the patch series with the fix to the problem. I will pull this into a separate test branch for us all to test different scenarios. I would like to make sure the repo will stay clean after install in the case of when out of tree builds.
Sorry I can't amend the patch as this isn't a trivial merge change. This change requires more testing.
thanks, -- Shuah
| ![\](/images/icornerr.gif) |