Messages in this thread | ![/](/images/icornerl.gif) | | Date | Tue, 9 Jan 2024 11:58:11 +0000 | Subject | Re: [PATCH v2 01/12] dt-bindings: clock: google,gs101-clock: add PERIC0 clock management unit | From | Tudor Ambarus <> |
| |
On 1/9/24 11:09, Krzysztof Kozlowski wrote: > On 09/01/2024 05:03, Rob Herring wrote: >> On Thu, Dec 28, 2023 at 12:57:54PM +0000, Tudor Ambarus wrote: >>> Add dt-schema documentation for the Connectivity Peripheral 0 (PERIC0) >>> clock management unit. >>> >>> Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org> >>> Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org> >>> --- >>> v2: >>> - fix comments as per Sam's suggestion and collect his R-b tag >>> - Rob's suggestion of renaming the clock-names to just "bus" and "ip" >>> was not implemented as I felt it affects readability in the driver >>> and consistency with other exynos clock drivers. I will happily update >>> the names in the -rc phase if someone else has a stronger opinion than >>> mine. >> >> I'll defer to Krzysztof. > > I miss the point why clock-names cannot be fixed now. This is the name > of property, not the input clock name.
They can be fixed now. I've just aired the fixes at: https://lore.kernel.org/linux-arm-kernel/20240109114908.3623645-1-tudor.ambarus@linaro.org/
Preparing v3 for this patch set to include the updated names here too.
Thanks, ta
| ![\](/images/icornerr.gif) |