Messages in this thread | | | From | Ilias Apalodimas <> | Date | Tue, 9 Jan 2024 09:02:02 +0200 | Subject | Re: [PATCH net-next v2] page_pool: Rename frag_users to pagecnt_bias |
| |
Hi Jakub,
On Wed, 3 Jan 2024 at 01:35, Jakub Kicinski <kuba@kernel.org> wrote: > > On Wed, 20 Dec 2023 10:01:46 +0200 Ilias Apalodimas wrote: > > - long frag_users; > > + long pagecnt_bias; > > IDK :( > > pagecnt to mean suggests this is related to page refcount, > not page pool specific refcount. > > More importantly bias is the large number by which we increment. > This counter counts how many of the bias references we actually > consumed. So how about bias_consumed? bias_used? bias_issued? > frags_alloced?
I had similar concerns, that's why v1 used 'frag_cnt'. I am fine with either frags_alloced or frag_cnt
Thanks /Ilias
| |