Messages in this thread | ![/](/images/icornerl.gif) | | Date | Wed, 24 Jan 2024 13:34:18 +0100 | Subject | Re: [PATCH] thermal/drivers/tsens: Add suspend to RAM support for tsens | From | Konrad Dybcio <> |
| |
On 1/24/24 11:42, Priyansh Jain wrote: > > > On 1/22/2024 8:02 PM, Konrad Dybcio wrote: >> On 22.01.2024 11:07, Priyansh Jain wrote: >>> Add suspend callback support for tsens which disables tsens interrupts >>> in suspend to RAM callback. >> >> Would it not be preferrable to have the "critical overheat", wakeup- >> capable interrupts be enabled, even if the system is suspended? >> > > > As part of suspend to RAM, tsens hardware will be turned off and it cannot generate any interrupt.Also system doesn't want to abort suspend to RAM due to tsens interrupts since system is already going into lowest > power state. Hence disabling tsens interrupt during suspend to RAM callback.
Is that a hardware limitation, or a software design choice? I'm not sure I want my phone to have thermal notifications disabled when it's suspended.
Konrad
| ![\](/images/icornerr.gif) |