Messages in this thread | | | Date | Wed, 24 Jan 2024 20:56:26 +0100 | From | "Arnd Bergmann" <> | Subject | Re: [PATCH 2/2] ARM: configs: keystone: Remove this defconfig |
| |
On Wed, Jan 24, 2024, at 19:52, Andrew Davis wrote: > On 1/24/24 12:04 PM, Nishanth Menon wrote: >> On 11:31-20240124, Andrew Davis wrote: >>> On 1/24/24 10:41 AM, Nishanth Menon wrote: >>>> >>>> There are a bunch of downstream folks who will have recipe fails etc if >>>> we do that. I am not sure we need to go down that route. >>>> >>> >>> That is the point of this patch, we want to stop any remaining downstream >>> folks from using this defconfig. It is not maintained nor updated like >>> the multi_v7_defconfig, any new or needed options will only be added to >>> multi-v7 defconfig. >>> >> >> I am going to have to defer to ARM maintainers what they think.. >> enabling LPAE etc in common multi_v7_config. >> > > We are not enabling LPAE in common multi_v7_config, that can't be > done as many plats do not support it. Keystone will use the new > multi_v7_lpae_defconfig which was just added: > > e9faf9b0b07a ("ARM: add multi_v7_lpae_defconfig") > > That is what prompted me to make this change, we now have a > commonish config that works for Keystone.
I think adding keystone to multi_v7_defconfig is a good idea here for the reasons you explained. I don't mind keeping the other one around as well though, since keystone is a bit special.
Arnd
| |