Messages in this thread | | | Date | Wed, 24 Jan 2024 10:51:49 -0800 | Subject | Re: [PATCH] x86/resctrl: Fix unneeded variable warning reported by kernel test robot | From | Reinette Chatre <> |
| |
Hi Boris,
On 1/24/2024 10:31 AM, Borislav Petkov wrote: > On Wed, Jan 24, 2024 at 10:25:17AM -0800, Reinette Chatre wrote: >> This can be confusing since it implies that the patch you mention >> introduces the issue but instead the variable has been unneeded since >> the original: >> 92bd5a139033 ("x86/resctrl: Add interface to write mbm_total_bytes_config") > > What I said. :)
Right from the start, yes.
> >> To help clarify you can mention this order of events and also add an >> appropriate "Fixes:" tag. >> >>> cocci warnings: (new ones prefixed by >>) >>>>> arch/x86/kernel/cpu/resctrl/rdtgroup.c:1621:5-8: Unneeded variable: "ret". Return " 0" on line 1655 >>> >>> Fix the warning by removing the variable "ret" and returning 0 directly. >> >> cocci warning was spot on*. This fix is not just a change to "make a >> warning go away" but instead fixing an actual problem. >> It can just be "Remove the unneeded variable and return 0 directly". > > I'll fix all up before applying.
Thank you very much. For what it is worth, I do agree with the actual fix and you can add: Acked-by: Reinette Chatre <reinette.chatre@intel.com>
> >> * I'll add a private setup with the goal to catch these earlier. > > Except that it doesn't fire with the patch that added the code. It looks > like the cocci script needs adjustment...
Reinette
| |