Messages in this thread | | | Date | Thu, 11 Jan 2024 17:43:54 +0100 | Subject | Re: [PATCH 3/6] arm64: dts: qcom: ipq5332: Add MDIO device tree | From | Krzysztof Kozlowski <> |
| |
On 11/01/2024 16:59, Jie Luo wrote: >>> + mux_1 { >>> + pins = "gpio28"; >>> + function = "mdio1"; >>> + drive-strength = <8>; >>> + bias-pull-up; >>> + }; >> >> I don't know why i'm asking this, because i don't really expect a >> usable answer. What sort of MUX is this? Should you be using one of >> the muxes in drivers/net/mdio/mdio-mux-* or something similar? >> >> Andrew > > Sorry for the confusion, the pin nodes are for the MDIO and MDC, these > PINs are used by the dedicated hardware MDIO block in the SoC. I will > update the node name from mux_0 to MDC, mux_1 to MDIO, to make it clear. > The driver for this node is drivers/net/mdio/mdio-ipq4019.c, it is not > related to the mdio-mux-* code.
NAK. Run dtbs_check tests on your DTS first.
Best regards, Krzysztof
| |