lkml.org 
[lkml]   [2024]   [Jan]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] serial: 8250_pci1xxxx: off by one in pci1xxxx_process_read_data()
On Wed, Jan 10, 2024 at 02:11:46PM -0500, Hugo Villeneuve wrote:
> On Wed, 10 Jan 2024 21:52:28 +0300
> Dan Carpenter <dan.carpenter@linaro.org> wrote:
>
> > These > comparisons should be >= to prevent writing one element beyond
> > the end of the rx_buff[] array. The buffer has RX_BUF_SIZE[] elements.
>
> Hi,
> your commit title message is very confusing and doesn't hint that this
> is a bug fix (or a potential bug fix)...
>

Most C programmers know what an "off by one" is... But sure I can add
"fix" to the subject. I debated either way, but left it off because the
subject was already too long.

regards,
dan carpenter


\
 
 \ /
  Last update: 2024-01-10 20:20    [W:0.026 / U:0.588 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site