Messages in this thread | | | Date | Wed, 10 Jan 2024 08:06:03 +0800 | Subject | Re: [PATCH 1/4] dt-bindings: reset: sophgo: support SG2042 | From | Chen Wang <> |
| |
On 2024/1/9 23:19, Krzysztof Kozlowski wrote: > On 09/01/2024 10:16, Chen Wang wrote: >> From: Chen Wang <unicorn_wang@outlook.com> >> >> Add bindings for the reset generator on the SOPHGO SG2042 RISC-V SoC. >> >> Signed-off-by: Chen Wang <unicorn_wang@outlook.com> > ... > >> +#define RST_UART2 31 >> + >> +#define RST_UART3 32 > No need for blank line above UART3. If there is going to be new > version/resend, please fix it. Ok, let's wait a while for other review comments, then I will fix it in next version. > > Anyway: > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > > --- > > This is an automated instruction, just in case, because many review tags > are being ignored. If you know the process, you can skip it (please do > not feel offended by me posting it here - no bad intentions intended). > If you do not know the process, here is a short explanation: > > Please add Acked-by/Reviewed-by/Tested-by tags when posting new > versions, under or above your Signed-off-by tag. Tag is "received", when > provided in a message replied to you on the mailing list. Tools like b4 > can help here. However, there's no need to repost patches *only* to add > the tags. The upstream maintainer will do that for tags received on the > version they apply. > > https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577 > > Best regards, > Krzysztof >
| |