Messages in this thread | | | Date | Fri, 30 Jun 2023 22:46:12 -0700 | From | Randy Dunlap <> | Subject | Re: [PATCH] powerpc: allow PPC_EARLY_DEBUG_CPM only when SERIAL_CPM=y |
| |
On 6/9/23 20:11, Randy Dunlap wrote: > Hi-- > > On 5/16/23 11:54, Pali Rohár wrote: >> On Tuesday 16 May 2023 08:28:54 Randy Dunlap wrote: >>> In a randconfig with CONFIG_SERIAL_CPM=m and >>> CONFIG_PPC_EARLY_DEBUG_CPM=y, there is a build error: >>> ERROR: modpost: "udbg_putc" [drivers/tty/serial/cpm_uart/cpm_uart.ko] undefined! >>> >>> Prevent the build error by allowing PPC_EARLY_DEBUG_CPM only when >>> SERIAL_CPM=y. >>> >>> Fixes: c374e00e17f1 ("[POWERPC] Add early debug console for CPM serial ports.") >>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org> >>> Cc: Scott Wood <scottwood@freescale.com> >>> Cc: Kumar Gala <galak@kernel.crashing.org> >>> Cc: "Pali Rohár" <pali@kernel.org> >>> Cc: Michael Ellerman <mpe@ellerman.id.au> >>> Cc: Nicholas Piggin <npiggin@gmail.com> >>> Cc: Christophe Leroy <christophe.leroy@csgroup.eu> >>> Cc: linuxppc-dev@lists.ozlabs.org >> >> Looks good, >> >> Reviewed-by: Pali Rohár <pali@kernel.org> > > I'm still seeing this build error in linux-next even with other (PPC) CPM > patches applied. >
Patchwork shows status as Superseded:
http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20230516152854.22465-1-rdunlap@infradead.org/
but I don't understand why or by what.
I'm going to resubmit the patch now.
>> >>> --- >>> arch/powerpc/Kconfig.debug | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff -- a/arch/powerpc/Kconfig.debug b/arch/powerpc/Kconfig.debug >>> --- a/arch/powerpc/Kconfig.debug >>> +++ b/arch/powerpc/Kconfig.debug >>> @@ -240,7 +240,7 @@ config PPC_EARLY_DEBUG_40x >>> >>> config PPC_EARLY_DEBUG_CPM >>> bool "Early serial debugging for Freescale CPM-based serial ports" >>> - depends on SERIAL_CPM >>> + depends on SERIAL_CPM=y >>> help >>> Select this to enable early debugging for Freescale chips >>> using a CPM-based serial port. This assumes that the bootwrapper >
-- ~Randy
| |