Messages in this thread | | | Date | Fri, 9 Jun 2023 16:31:52 +0200 | Subject | Re: [RESEND 05/15] drm/mediatek/mtk_disp_ccorr: Remove half completed incorrect struct header | From | Matthias Brugger <> |
| |
On 09/06/2023 10:17, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/mediatek/mtk_disp_ccorr.c:47: warning: Function parameter or member 'clk' not described in 'mtk_disp_ccorr' > drivers/gpu/drm/mediatek/mtk_disp_ccorr.c:47: warning: Function parameter or member 'regs' not described in 'mtk_disp_ccorr' > drivers/gpu/drm/mediatek/mtk_disp_ccorr.c:47: warning: Function parameter or member 'cmdq_reg' not described in 'mtk_disp_ccorr' > drivers/gpu/drm/mediatek/mtk_disp_ccorr.c:47: warning: Function parameter or member 'data' not described in 'mtk_disp_ccorr' > > Cc: Chun-Kuang Hu <chunkuang.hu@kernel.org> > Cc: Philipp Zabel <p.zabel@pengutronix.de> > Cc: David Airlie <airlied@gmail.com> > Cc: Daniel Vetter <daniel@ffwll.ch> > Cc: Matthias Brugger <matthias.bgg@gmail.com> > Cc: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > Cc: dri-devel@lists.freedesktop.org > Cc: linux-mediatek@lists.infradead.org > Cc: linux-arm-kernel@lists.infradead.org > Signed-off-by: Lee Jones <lee@kernel.org> > --- > drivers/gpu/drm/mediatek/mtk_disp_ccorr.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ccorr.c b/drivers/gpu/drm/mediatek/mtk_disp_ccorr.c > index 1773379b24398..720f3c7ef7b4f 100644 > --- a/drivers/gpu/drm/mediatek/mtk_disp_ccorr.c > +++ b/drivers/gpu/drm/mediatek/mtk_disp_ccorr.c > @@ -34,11 +34,6 @@ struct mtk_disp_ccorr_data { > u32 matrix_bits; > }; > > -/** > - * struct mtk_disp_ccorr - DISP_CCORR driver structure > - * @ddp_comp - structure containing type enum and hardware resources > - * @crtc - associated crtc to report irq events to > - */
That surely suppress the warning but I think the correct to do here is to fix the documentation instead of deleting it.
Regards, Matthias
> struct mtk_disp_ccorr { > struct clk *clk; > void __iomem *regs;
| |