Messages in this thread | | | Date | Fri, 9 Jun 2023 17:19:49 +0530 | Subject | Re: [PATCH V3 3/5] clk: qcom: camcc-sm8550: Add camera clock controller driver for SM8550 | From | Jagadeesh Kona <> |
| |
Hi Dmitry,
Thanks for your review!
On 6/1/2023 8:21 PM, Dmitry Baryshkov wrote: > On 01/06/2023 17:34, Jagadeesh Kona wrote: >> Add support for the camera clock controller for camera clients to be >> able to request for camcc clocks on SM8550 platform. >> >> Co-developed-by: Taniya Das <quic_tdas@quicinc.com> >> Signed-off-by: Taniya Das <quic_tdas@quicinc.com> >> Signed-off-by: Jagadeesh Kona <quic_jkona@quicinc.com> >> --- >> Changes since V2: >> - No changes >> Changes since V1: >> - Sorted the PLL names in proper order >> - Updated all PLL configurations to lower case hex >> - Reused evo ops instead of adding new ops for ole pll >> - Moved few clocks to separate patch to fix patch too long error >> >> drivers/clk/qcom/Kconfig | 7 + >> drivers/clk/qcom/Makefile | 1 + >> drivers/clk/qcom/camcc-sm8550.c | 3405 +++++++++++++++++++++++++++++++ >> 3 files changed, 3413 insertions(+) >> create mode 100644 drivers/clk/qcom/camcc-sm8550.c >> > > [skipped] > >> + >> +static struct platform_driver cam_cc_sm8550_driver = { >> + .probe = cam_cc_sm8550_probe, >> + .driver = { >> + .name = "cam_cc-sm8550", >> + .of_match_table = cam_cc_sm8550_match_table, >> + }, >> +}; >> + >> +static int __init cam_cc_sm8550_init(void) >> +{ >> + return platform_driver_register(&cam_cc_sm8550_driver); >> +} >> +subsys_initcall(cam_cc_sm8550_init); >> + >> +static void __exit cam_cc_sm8550_exit(void) >> +{ >> + platform_driver_unregister(&cam_cc_sm8550_driver); >> +} >> +module_exit(cam_cc_sm8550_exit); > > Please convert this to use module_platform_driver >
We still have to evaluate if module_platform_driver() works for us in all scenarios. We will post a cleanup patch once we conclude on module_platform_driver().
>> + >> +MODULE_DESCRIPTION("QTI CAMCC SM8550 Driver"); >> +MODULE_LICENSE("GPL"); >
Thanks & Regards, Jagadeesh
| |