Messages in this thread | | | Date | Fri, 9 Jun 2023 17:35:39 +0800 | From | kernel test robot <> | Subject | arch/powerpc/include/asm/hw_irq.h:494 mtmsr_isync_irqsafe() warn: inconsistent indenting |
| |
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 33f2b5785a2b6b0ed1948aafee60d3abb12f1e3a commit: 0fa6831811f62cfc10415d731bcf9fde2647ad81 powerpc/64: Fix msr_check_and_set/clear MSR[EE] race date: 8 months ago config: powerpc-randconfig-m031-20230608 (https://download.01.org/0day-ci/archive/20230609/202306091705.0mLF1ntp-lkp@intel.com/config) compiler: powerpc-linux-gcc (GCC) 12.3.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202306091705.0mLF1ntp-lkp@intel.com/
New smatch warnings: arch/powerpc/include/asm/hw_irq.h:494 mtmsr_isync_irqsafe() warn: inconsistent indenting
Old smatch warnings: arch/powerpc/kernel/process.c:445 giveup_all() warn: bitwise AND condition is false here arch/powerpc/kernel/process.c:587 save_all() warn: bitwise AND condition is false here
vim +494 arch/powerpc/include/asm/hw_irq.h
473 474 static inline unsigned long mtmsr_isync_irqsafe(unsigned long msr) 475 { 476 #ifdef CONFIG_PPC64 477 if (arch_irqs_disabled()) { 478 /* 479 * With soft-masking, MSR[EE] can change from 1 to 0 480 * asynchronously when irqs are disabled, and we don't want to 481 * set MSR[EE] back to 1 here if that has happened. A race-free 482 * way to do this is ensure EE is already 0. Another way it 483 * could be done is with a RESTART_TABLE handler, but that's 484 * probably overkill here. 485 */ 486 msr &= ~MSR_EE; 487 mtmsr_isync(msr); 488 irq_soft_mask_set(IRQS_ALL_DISABLED); 489 local_paca->irq_happened |= PACA_IRQ_HARD_DIS; 490 } else 491 #endif 492 mtmsr_isync(msr); 493 > 494 return msr; 495 } 496
-- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
| |