Messages in this thread | | | From | Linus Walleij <> | Date | Fri, 9 Jun 2023 09:49:08 +0200 | Subject | Re: [PATCH V2] gpio: zynq: fix zynqmp_gpio not an immutable chip warning |
| |
On Thu, Jun 8, 2023 at 8:43 PM Manikanta Guntupalli <manikanta.guntupalli@amd.com> wrote:
> Make the struct irq_chip const and flag it as IRQCHIP_IMMUTABLE, > call gpiochip_disable_irq() in the .irq_mask() callback and > gpiochip_enable_irq() in the .irq_unmask() callback to fix > "gpio gpiochip1: (zynqmp_gpio): not an immutable chip" warning. > > Signed-off-by: Manikanta Guntupalli <manikanta.guntupalli@amd.com>
This v2 looks good to me! Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours, Linus Walleij
| |