Messages in this thread | | | From | Doug Anderson <> | Date | Thu, 8 Jun 2023 06:38:40 -0700 | Subject | Re: [PATCH v4 2/2] HID: i2c-hid: elan: Add ili9882t timing |
| |
Hi,
On Thu, Jun 8, 2023 at 6:02 AM Cong Yang <yangcong5@huaqin.corp-partner.google.com> wrote: > > +static const struct elan_i2c_hid_chip_data ilitek_ili9882t_chip_data = { > + .post_power_delay_ms = 1, > + .post_gpio_reset_on_delay_ms = 200, > + .post_gpio_reset_off_delay_ms = 65, > .hid_descriptor_address = 0x0001, > + /* this touchscreen is tightly integrated with the panel and assumes > + * that the relevant power rails (other than the IO rail) have already > + * been turned on by the panel driver because we're a panel follower. > + */
I don't think the above is the right block comment style for this file. The first "/*" should be on a line on its own.
> + .main_supply_name = "null",
This should actually be NULL without the quotes. ...then you should change the code not to try to grab the regulator in that case.
| |