lkml.org 
[lkml]   [2023]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 1/1] net/sched: cls_u32: Fix reference counter leak leading to overflow
On Thu, 08 Jun 2023, Eric Dumazet wrote:

> On Thu, Jun 8, 2023 at 9:29 AM Lee Jones <lee@kernel.org> wrote:
> >
> > In the event of a failure in tcf_change_indev(), u32_set_parms() will
> > immediately return without decrementing the recently incremented
> > reference counter. If this happens enough times, the counter will
> > rollover and the reference freed, leading to a double free which can be
> > used to do 'bad things'.
> >
> > In order to prevent this, move the point of possible failure above the
> > point where the reference counter is incremented. Also save any
> > meaningful return values to be applied to the return data at the
> > appropriate point in time.
> >
> > This issue was caught with KASAN.
> >
> > Fixes: 705c7091262d ("net: sched: cls_u32: no need to call tcf_exts_change for newly allocated struct")
> > Suggested-by: Eric Dumazet <edumazet@google.com>
> > Signed-off-by: Lee Jones <lee@kernel.org>
> > ---
>
> Thanks Lee !

No problem. Thanks for your help.

> Reviewed-by: Eric Dumazet <edumazet@google.com>

--
Lee Jones [李琼斯]

\
 
 \ /
  Last update: 2023-06-08 09:48    [W:0.123 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site