Messages in this thread | | | Date | Wed, 7 Jun 2023 11:53:16 -0700 | Subject | Re: [PATCH v2] ufs: core: Combine ufshcd_mq_poll_cqe functions | From | Bart Van Assche <> |
| |
On 6/1/23 15:50, Stanley Chu wrote: > Currently, ufshcd_mcq_poll_cqe_nolock() is only called by > ufshcd_mcq_poll_cqe_lock() with the addition of a spinlock wrapper > for ufshcd_mcq_poll_cqe_nolock(). Combining these two functions > into one would result in cleaner code.
For future patches, please use the imperative mood for the patch description ("would result in" -> "results in"). Additionally, a follow-up patch that renames ufshcd_mcq_poll_cqe_lock() into ufshcd_mcq_poll_cqe() would be welcome. Anyway:
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
| |