lkml.org 
[lkml]   [2023]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] scsi: ufs-mediatek: add dependency for RESET_CONTROLLER
From
On 6/1/23 19:39, Randy Dunlap wrote:
> When RESET_CONTROLLER is not set, kconfig complains about missing
> dependencies for RESET_TI_SYSCON, so add the missing dependency
> just as is done above for SCSI_UFS_QCOM.
>
> Silences this kconfig warning:
>
> WARNING: unmet direct dependencies detected for RESET_TI_SYSCON
> Depends on [n]: RESET_CONTROLLER [=n] && HAS_IOMEM [=y]
> Selected by [m]:
> - SCSI_UFS_MEDIATEK [=m] && SCSI_UFSHCD [=y] && SCSI_UFSHCD_PLATFORM [=y] && ARCH_MEDIATEK [=y]
>
> Fixes: de48898d0cb6 ("scsi: ufs-mediatek: Create reset control device_link")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Reported-by: kernel test robot <lkp@intel.com>
> Link: lore.kernel.org/r/202306020859.1wHg9AaT-lkp@intel.com
> Cc: Stanley Chu <stanley.chu@mediatek.com>
> Cc: Peter Wang <peter.wang@mediatek.com>
> Cc: Paul Gazzillo <paul@pgazz.com>
> Cc: Necip Fazil Yildiran <fazilyildiran@gmail.com>
> Cc: linux-scsi@vger.kernel.org
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-mediatek@lists.infradead.org
> Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
> Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
> ---
> drivers/ufs/host/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff -- a/drivers/ufs/host/Kconfig b/drivers/ufs/host/Kconfig
> --- a/drivers/ufs/host/Kconfig
> +++ b/drivers/ufs/host/Kconfig
> @@ -72,6 +72,7 @@ config SCSI_UFS_QCOM
> config SCSI_UFS_MEDIATEK
> tristate "Mediatek specific hooks to UFS controller platform driver"
> depends on SCSI_UFSHCD_PLATFORM && ARCH_MEDIATEK
> + depends on RESET_CONTROLLER
> select PHY_MTK_UFS
> select RESET_TI_SYSCON
> help

Hmm ... is the above patch complete? Shouldn't a similar dependency be
added to the ufs-hisi and ufs-sprd drivers? See also the following git
grep output:

$ git grep -nH 'include.*linux/reset.h' */ufs
drivers/ufs/host/ufs-hisi.c:16:#include <linux/reset.h>
drivers/ufs/host/ufs-mediatek.c:21:#include <linux/reset.h>
drivers/ufs/host/ufs-qcom.h:9:#include <linux/reset.h>
drivers/ufs/host/ufs-sprd.c:14:#include <linux/reset.h>

Thanks,

Bart.

\
 
 \ /
  Last update: 2023-06-07 19:18    [W:0.049 / U:2.560 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site