lkml.org 
[lkml]   [2023]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] xen-blkback: Inform userspace that device has been opened
On Wed, Jun 07, 2023 at 12:46:16AM -0700, Christoph Hellwig wrote:
> > --- a/drivers/block/xen-blkback/xenbus.c
> > +++ b/drivers/block/xen-blkback/xenbus.c
> > @@ -3,6 +3,20 @@
> > Copyright (C) 2005 Rusty Russell <rusty@rustcorp.com.au>
> > Copyright (C) 2005 XenSource Ltd
> >
> > +In addition to the Xenstore nodes required by the Xen block device
> > +specification, this implementation of blkback uses a new Xenstore
> > +node: "opened". blkback sets "opened" to "0" before the hotplug script
> > +is called. Once the device node has been opened, blkback sets "opened"
> > +to "1".
>
> This is a really odd comment style, and a really strange place for it.
> To me it feels like this should just be a file in Documentation as it
> relates to how to use the driver, and doesn't really explain the code.

Will fix in v3.
--
Sincerely,
Demi Marie Obenour (she/her/hers)
Invisible Things Lab
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2023-06-07 18:02    [W:0.022 / U:0.284 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site