lkml.org 
[lkml]   [2023]   [Jun]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 03/12] arm64: dts: ti: k3-j721e-beagleboneai64: Fixup reference to phandles array
From
Hi Nishanth

On 6/1/2023 8:56 PM, Nishanth Menon wrote:
> When referring to array of phandles, using <> to separate the array
> entries is better notation as it makes potential errors with phandle and
> cell arguments easier to catch. Fix the outliers to be consistent with
> the rest of the usage.
>
> Cc: Robert Nelson <robertcnelson@gmail.com>
> Signed-off-by: Nishanth Menon <nm@ti.com>
> ---
> .../boot/dts/ti/k3-j721e-beagleboneai64.dts | 29 ++++++++++---------
> 1 file changed, 15 insertions(+), 14 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts b/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts
> index 37c24b077b6a..c13246a9ed8f 100644
> --- a/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts
> +++ b/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts
> @@ -593,7 +593,7 @@ &main_i2c0 {
> &main_i2c1 {
> status = "okay";
> pinctrl-names = "default";
> - pinctrl-0 = <&main_i2c1_pins_default &csi1_gpio_pins_default>;
> + pinctrl-0 = <&main_i2c1_pins_default>, <&csi1_gpio_pins_default>;
> clock-frequency = <400000>;
> };
>
> @@ -623,7 +623,7 @@ &main_i2c4 {
> &main_i2c5 {
> status = "okay";
> pinctrl-names = "default";
> - pinctrl-0 = <&main_i2c5_pins_default &csi0_gpio_pins_default>;
> + pinctrl-0 = <&main_i2c5_pins_default>, <&csi0_gpio_pins_default>;
> clock-frequency = <400000>;
> };
>
> @@ -639,7 +639,7 @@ &main_i2c6 {
> &wkup_i2c0 {
> status = "okay";
> pinctrl-names = "default";
> - pinctrl-0 = <&wkup_i2c0_pins_default &eeprom_wp_pins_default>;
> + pinctrl-0 = <&wkup_i2c0_pins_default>, <&eeprom_wp_pins_default>;
> clock-frequency = <400000>;

Why we need more than 2 pio lines for i2c node ,


> [...]
>

\
 
 \ /
  Last update: 2023-06-05 19:02    [W:1.028 / U:0.852 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site