lkml.org 
[lkml]   [2023]   [Jun]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH RESEND 4/4] arm64: dts: qcom: ipq5332: add support for the RDP474 variant
From

On 6/1/2023 10:59 PM, Krzysztof Kozlowski wrote:
> On 01/06/2023 06:20, Kathiravan T wrote:
>> Add the initial device tree support for the Reference Design
>> Platform(RDP) 474 based on IPQ5332 family of SoC. This patch carries
>> the support for Console UART, eMMC, I2C and GPIO based buttons.
>>
>> Signed-off-by: Kathiravan T <quic_kathirav@quicinc.com>
>> ---
>> arch/arm64/boot/dts/qcom/Makefile | 1 +
>> arch/arm64/boot/dts/qcom/ipq5332-rdp474.dts | 112 ++++++++++++++++++++
>> 2 files changed, 113 insertions(+)
>> create mode 100644 arch/arm64/boot/dts/qcom/ipq5332-rdp474.dts
>>
>> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
>> index 4f9e81253e18..0f8c763a9bd9 100644
>> --- a/arch/arm64/boot/dts/qcom/Makefile
>> +++ b/arch/arm64/boot/dts/qcom/Makefile
>> @@ -7,6 +7,7 @@ dtb-$(CONFIG_ARCH_QCOM) += apq8096-ifc6640.dtb
>> dtb-$(CONFIG_ARCH_QCOM) += ipq5332-mi01.2.dtb
>> dtb-$(CONFIG_ARCH_QCOM) += ipq5332-rdp442.dtb
>> dtb-$(CONFIG_ARCH_QCOM) += ipq5332-rdp468.dtb
>> +dtb-$(CONFIG_ARCH_QCOM) += ipq5332-rdp474.dtb
>> dtb-$(CONFIG_ARCH_QCOM) += ipq6018-cp01-c1.dtb
>> dtb-$(CONFIG_ARCH_QCOM) += ipq8074-hk01.dtb
>> dtb-$(CONFIG_ARCH_QCOM) += ipq8074-hk10-c1.dtb
>> diff --git a/arch/arm64/boot/dts/qcom/ipq5332-rdp474.dts b/arch/arm64/boot/dts/qcom/ipq5332-rdp474.dts
>> new file mode 100644
>> index 000000000000..085729a0fdf1
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/qcom/ipq5332-rdp474.dts
>> @@ -0,0 +1,112 @@
>> +// SPDX-License-Identifier: BSD-3-Clause
>> +/*
>> + * IPQ5332 RDP474 board device tree source
>> + *
>> + * Copyright (c) 2022-2023 Qualcomm Innovation Center, Inc. All rights reserved.
>> + */
>> +
>> +/dts-v1/;
>> +
>> +#include <dt-bindings/gpio/gpio.h>
>> +#include <dt-bindings/input/input.h>
>> +#include "ipq5332.dtsi"
>> +
>> +/ {
>> + model = "Qualcomm Technologies, Inc. IPQ5332 MI01.9";
>> + compatible = "qcom,ipq5332-ap-mi01.9", "qcom,ipq5332";
>> +
>> + aliases {
>> + serial0 = &blsp1_uart0;
>> + };
>> +
>> + chosen {
>> + stdout-path = "serial0";
>> + };
>> +
>> + gpio_keys {
> No, srsly, so not only ignored the tags but also feedback?


Please correct me if I am wrong here..

This is RESEND of V1 patches (only minor correction in the subject line
in cover letter). Also I don't see review comments as such in original
V1 as well
https://lore.kernel.org/linux-arm-msm/20230531135048.19164-1-quic_kathirav@quicinc.com/

Can you help to point out your review comments, I couldn't able to find out.

Thanks,


>
> Best regards,
> Krzysztof
>

\
 
 \ /
  Last update: 2023-06-02 06:06    [W:0.068 / U:1.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site