Messages in this thread | ![/](/images/icornerl.gif) | | Date | Wed, 14 Jun 2023 08:29:10 +0530 | Subject | Re: [PATCH V11 02/10] arm64/perf: Add BRBE registers and fields | From | Anshuman Khandual <> |
| |
On 6/13/23 21:57, Mark Rutland wrote: > On Wed, May 31, 2023 at 09:34:20AM +0530, Anshuman Khandual wrote: >> This adds BRBE related register definitions and various other related field >> macros there in. These will be used subsequently in a BRBE driver which is >> being added later on. >> >> Cc: Catalin Marinas <catalin.marinas@arm.com> >> Cc: Will Deacon <will@kernel.org> >> Cc: Marc Zyngier <maz@kernel.org> >> Cc: Mark Rutland <mark.rutland@arm.com> >> Cc: linux-arm-kernel@lists.infradead.org >> Cc: linux-kernel@vger.kernel.org >> Tested-by: James Clark <james.clark@arm.com> >> Reviewed-by: Mark Brown <broonie@kernel.org> >> Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com> >> --- >> arch/arm64/include/asm/sysreg.h | 103 +++++++++++++++++++++ >> arch/arm64/tools/sysreg | 159 ++++++++++++++++++++++++++++++++ >> 2 files changed, 262 insertions(+) > >> +SysregFields BRBINFx_EL1 > >> +Enum 1:0 VALID >> + 0b00 NONE >> + 0b01 TARGET >> + 0b10 SOURCE >> + 0b11 FULL >> +EndEnum > > This looks correct... > > [...] > >> +Sysreg BRBINFINJ_EL1 2 1 9 1 0 > >> +Enum 1:0 VALID >> + 0b00 NONE >> + 0b01 TARGET >> + 0b10 SOURCE >> + 0b00 FULL >> +EndEnum > > ... but this clearly isn't.
Fixed VALID_FULL as 0b11.
| ![\](/images/icornerr.gif) |