Messages in this thread | | | Date | Mon, 12 Jun 2023 16:17:19 +0200 | From | "Arnd Bergmann" <> | Subject | Re: [PATCH] remoteproc: stm32: use correct format strings on 64-bit |
| |
On Mon, Jun 12, 2023, at 16:10, Arnaud POULIQUEN wrote:
>> ddata->rsc_va = devm_ioremap_wc(dev, rsc_pa, RSC_TBL_SIZE); >> if (IS_ERR_OR_NULL(ddata->rsc_va)) { >> - dev_err(dev, "Unable to map memory region: %pa+%zx\n", >> + dev_err(dev, "Unable to map memory region: %pa+%x\n", >> &rsc_pa, RSC_TBL_SIZE); > > What about cast the RSC_TBL_SIZE define instead to ensure to be independent from > the arch and to match with the use of RSC_TBL_SIZE? > > #define RSC_TBL_SIZE ((size_t)1024)
I have no objection to that, but I don't see it doing anything good either, as this is a constant value that will always work.
Arnd
| |