lkml.org 
[lkml]   [2023]   [Jun]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] remoteproc: stm32: use correct format strings on 64-bit
On Mon, Jun 12, 2023, at 16:10, Arnaud POULIQUEN wrote:

>> ddata->rsc_va = devm_ioremap_wc(dev, rsc_pa, RSC_TBL_SIZE);
>> if (IS_ERR_OR_NULL(ddata->rsc_va)) {
>> - dev_err(dev, "Unable to map memory region: %pa+%zx\n",
>> + dev_err(dev, "Unable to map memory region: %pa+%x\n",
>> &rsc_pa, RSC_TBL_SIZE);
>
> What about cast the RSC_TBL_SIZE define instead to ensure to be independent from
> the arch and to match with the use of RSC_TBL_SIZE?
>
> #define RSC_TBL_SIZE ((size_t)1024)

I have no objection to that, but I don't see it doing anything good either,
as this is a constant value that will always work.

Arnd

\
 
 \ /
  Last update: 2023-06-12 16:23    [W:0.372 / U:0.412 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site