lkml.org 
[lkml]   [2023]   [Jun]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: [PATCH RFC net-next v4 4/8] vsock: make vsock bind reusable
    On Sat, Jun 10, 2023 at 12:58:31AM +0000, Bobby Eshleman wrote:
    > This commit makes the bind table management functions in vsock usable
    > for different bind tables. For use by datagrams in a future patch.
    >
    > Signed-off-by: Bobby Eshleman <bobby.eshleman@bytedance.com>
    > ---
    > net/vmw_vsock/af_vsock.c | 33 ++++++++++++++++++++++++++-------
    > 1 file changed, 26 insertions(+), 7 deletions(-)
    >
    > diff --git a/net/vmw_vsock/af_vsock.c b/net/vmw_vsock/af_vsock.c
    > index ef86765f3765..7a3ca4270446 100644
    > --- a/net/vmw_vsock/af_vsock.c
    > +++ b/net/vmw_vsock/af_vsock.c
    > @@ -230,11 +230,12 @@ static void __vsock_remove_connected(struct vsock_sock *vsk)
    > sock_put(&vsk->sk);
    > }
    >
    > -static struct sock *__vsock_find_bound_socket(struct sockaddr_vm *addr)
    > +struct sock *vsock_find_bound_socket_common(struct sockaddr_vm *addr,
    > + struct list_head *bind_table)

    Hi Bobby,

    This function seems to only be used in this file.
    Should it be static?

    \
     
     \ /
      Last update: 2023-06-12 12:11    [W:4.107 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site