Messages in this thread | | | Date | Thu, 1 Jun 2023 15:12:31 +0100 | From | Jonathan Cameron <> | Subject | Re: [PATCH v4 20/23] cxl/pci: Prepare for logging RCH downstream port protocol errors |
| |
On Thu, 1 Jun 2023 09:06:23 -0500 Terry Bowman <Terry.Bowman@amd.com> wrote:
> Hi Jonathan, thanks for reviewing. > > On 6/1/23 08:49, Jonathan Cameron wrote: > > On Tue, 23 May 2023 18:22:11 -0500 > > Terry Bowman <terry.bowman@amd.com> wrote: > > > > The title is very vague. Can it be more specific to what > > is in this patch? The description makes it seem like a bunch of > > unconnected things, but in reality they all chain together > > to get the registers and disable the interrupt. > > > > How about I split this into 2 patches (along lines of register mapping > and root port interrupt disable) and title as: > cxl/pci: Map RCH downstream registers for AER protocol error logging > cxl/pci: Disable root port interrupts in RCH mode
Sounds good to me.
Jonathan
| |