Messages in this thread | | | Date | Thu, 1 Jun 2023 17:14:43 +0800 | Subject | Re: [PATCH v3 0/4] Fix some warnings about rq clock | From | Hao Jia <> |
| |
Kindly ping, any comment?
Thanks, Hao
On 2023/5/15 Hao Jia wrote: > These four patches fix some warnings about rq clock. > > Patch1 fixes the warning of using the old rq clock caused by > missing update rq clock. > > Patch2-4 fixes the warning that the rq clock was updated multiple > times while holding the rq lock. > > v2->v3: > - Modify the commit information of patch1 to make the description clearer. > - Split v2 patch2 into 3 separate patches. > > v1->v2: > - Vincent Guittot suggested using rq_clock_start_loop_update() > to prevent multiple calls to update_rq_clock() in unthrottle_cfs_rq() > instead of removing update_rq_clock() from unthrottle_cfs_rq() > and updating the rq clock before unthrottle_cfs_rq() for patch2. > > [v2] https://lore.kernel.org/all/20230510083450.62334-1-jiahao.os@bytedance.com > [v1] https://lore.kernel.org/all/20230410081206.23441-1-jiahao.os@bytedance.com > > > Hao Jia (4): > sched/core: Fixed missing rq clock update before calling > set_rq_offline() > sched/core: Avoid double calling update_rq_clock() in > __balance_push_cpu_stop() > sched/core: Avoid multiple calling update_rq_clock() in > __cfsb_csd_unthrottle() > sched/core: Avoid multiple calling update_rq_clock() in > unthrottle_offline_cfs_rqs() > > kernel/sched/core.c | 7 ++++--- > kernel/sched/fair.c | 18 ++++++++++++++++++ > kernel/sched/sched.h | 21 +++++++++++++++++++++ > kernel/sched/topology.c | 10 ++++++---- > 4 files changed, 49 insertions(+), 7 deletions(-) >
| |