Messages in this thread | | | From | Ard Biesheuvel <> | Date | Thu, 1 Jun 2023 10:35:01 +0200 | Subject | Re: [PATCH] ARM: Replace all non-returning strlcpy with strscpy |
| |
On Wed, 31 May 2023 at 15:30, Linus Walleij <linus.walleij@linaro.org> wrote: > > On Tue, May 30, 2023 at 5:55 PM Azeem Shaikh <azeemshaikh38@gmail.com> wrote: > > > strlcpy() reads the entire source buffer first. > > This read may exceed the destination size limit. > > This is both inefficient and can lead to linear read > > overflows if a source string is not NUL-terminated [1]. > > In an effort to remove strlcpy() completely [2], replace > > strlcpy() here with strscpy(). > > No return values were used, so direct replacement is safe. > > > > [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy > > [2] https://github.com/KSPP/linux/issues/89 > > > > Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com> > > Reviewed-by: Linus Walleij <linus.walleij@linaro.org> > > Please put this into Russell's patch tracker: > https://www.arm.linux.org.uk/developer/patches/ >
https://www.armlinux.org.uk/developer/patches/viewpatch.php?id=9300/1
| |