lkml.org 
[lkml]   [2023]   [Jun]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v2 3/3] dt-bindings: phy: realtek: Add the doc about the Realtek SoC USB 2.0/3.0 PHY
Date
Hi Krzysztof,

> >
> > Most of the properties are about the phy parameters.
> > Is the phy parameter data suitable to be placed in DTS?
> > I referenced other phy drivers.
> > These parameters should not be defined in dts.
> > I would move the parameters to the driver.
>
> If these can be in the driver, why would ever they be in DTS in the first place?
>
Our platforms have 3 xhci controllers which map to 3 different phy ports.
And the three phy ports use the same driver, but the parameters are different.
So I put the parameter settings in DTS, we have 3 usb-phy nodes representing 3 phy ports.
Also, some parameters have to be adjusted for different boards.
Therefore, it is more applicable in DTS than in driver.

> >>> + realtek,usb:
> >>> + description: The phandler of realtek dwc3 node
> >>
> >> "phandler"? Except obvious typo, drop "The phandler of" and describe
> >> what is it for.
> >
> > realtek,usb is a phandle of syscon used to control realtek dwc3 register.
>
> Then no, phy should not control dwc3.

OK I know it doesn't make sense.
We want to disable phy suspend from mac layer.
I will try other method.

> >
> >>> + $ref: /schemas/types.yaml#/definitions/phandle
> >>
> >> Anyway, it shouldn't be here. No, no.
> >
> > Can I use it for phandle of syscon?
>
> PHY getting phandle to block using this PHY? Looks wrong. Why would PHY
> need to poke IP block register?
>

OK. I know it doesn't make sense.
\
 
 \ /
  Last update: 2023-06-02 05:23    [W:1.451 / U:0.000 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site