Messages in this thread | | | Subject | Re: [PATCH v5] checkpatch: Check for 0-length and 1-element arrays | From | Joe Perches <> | Date | Thu, 01 Jun 2023 19:24:59 -0700 |
| |
On Thu, 2023-06-01 at 15:15 -0700, Andrew Morton wrote: > On Thu, 1 Jun 2023 09:07:46 -0700 Kees Cook <keescook@chromium.org> wrote: > > > Fake flexible arrays have been deprecated since last millennium. Proper > > C99 flexible arrays must be used throughout the kernel so > > CONFIG_FORTIFY_SOURCE and CONFIG_UBSAN_BOUNDS can provide proper array > > bounds checking. > > > > Cc: Andy Whitcroft <apw@canonical.com> > > Cc: Dwaipayan Ray <dwaipayanray1@gmail.com> > > Cc: Lukas Bulwahn <lukas.bulwahn@gmail.com> > > Fixed-by: Joe Perches <joe@perches.com> > > You didn't checkpatch your checkpatch patch! > > WARNING: Non-standard signature: Fixed-by: > #248: > Fixed-by: Joe Perches <joe@perches.com> > > I'll do my usual > > [joe@perches.com: handle __packed for srtucts]
With that spelling?
Anyway, I went back and forth a few times with Kees giving suggestions and corrections before sending it on to you for more than just __packed.
I didn't (and still don't) care much about anything other than the code.
cheers, Joe
| |