lkml.org 
[lkml]   [2023]   [Jun]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v5 3/9] serial: sc16is7xx: refactor GPIO controller registration
Hugo Villeneuve schreef op 2023-06-01 18:31:
> From: Hugo Villeneuve <hvilleneuve@dimonoff.com>
>
> In preparation for upcoming patch "fix regression with GPIO
> configuration". To facilitate review and make code more modular.
>
> Cc: <stable@vger.kernel.org> # 6.1.x
> Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com>
> Reviewed-by: Lech Perczak <lech.perczak@camlingroup.com>
> Tested-by: Lech Perczak <lech.perczak@camlingroup.com>
> ---
> drivers/tty/serial/sc16is7xx.c | 39 ++++++++++++++++++++--------------
> 1 file changed, 23 insertions(+), 16 deletions(-)
>
> diff --git a/drivers/tty/serial/sc16is7xx.c
> b/drivers/tty/serial/sc16is7xx.c
> index 0c903d44429c..279d7dcb1447 100644
> --- a/drivers/tty/serial/sc16is7xx.c
> +++ b/drivers/tty/serial/sc16is7xx.c
> @@ -1349,6 +1349,26 @@ static int
> sc16is7xx_gpio_direction_output(struct gpio_chip *chip,
>
> return 0;
> }
> +
> +static int sc16is7xx_setup_gpio_chip(struct device *dev)

Only one parameter, but...

> + ret = sc16is7xx_setup_gpio_chip(dev, mctrl_mask);

called with two.

Maarten

\
 
 \ /
  Last update: 2023-06-01 19:59    [W:0.067 / U:0.588 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site