Messages in this thread | | | Date | Thu, 1 Jun 2023 17:35:49 +0000 | From | Carlos Llamas <> | Subject | Re: [PATCH] scripts/tags.sh: improve compiled sources generation |
| |
On Thu, Jun 01, 2023 at 09:04:02AM +0800, Jialu Xu wrote: > Use grep instead of sed for all compiled sources generation, it is three > times more efficient.
Although I'm not sure how you obtained a 3x efficiency it did make things faster for me. I suppose there are several factors involved. I used defconfig for arm64 and got the following results: real 1m50.790s real 1m27.907s (with patch)
Tested-by: Carlos Llamas <cmllamas@google.com>
> > Signed-off-by: Jialu Xu <xujialu@vimux.org> > --- > scripts/tags.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/tags.sh b/scripts/tags.sh > index ea31640b2671..938dba219534 100755 > --- a/scripts/tags.sh > +++ b/scripts/tags.sh > @@ -98,7 +98,7 @@ all_compiled_sources() > { > echo include/generated/autoconf.h > find $ignore -name "*.cmd" -exec \ > - sed -n -E 's/^source_.* (.*)/\1/p; s/^ (\S.*) \\/\1/p' {} \+ | > + grep -Poh '(?<=^ )\S+|(?<== )\S+[^\\](?=$)' {} \+ | > awk '!a[$0]++' > } | xargs realpath -esq $([ -z "$KBUILD_ABS_SRCTREE" ] && echo --relative-to=.) | > sort -u > -- > 2.30.2 >
| |