lkml.org 
[lkml]   [2023]   [Jun]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 2/4] soundwire: bandwidth allocation: Remove pointless variable
From


On 6/1/23 11:16, Charles Keepax wrote:
> The block_offset variable in _sdw_compute_port_params adds nothing
> either functionally or in terms of code clarity, remove it.
>
> Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>

This one is easy enough, thanks!

Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>

> ---
> drivers/soundwire/generic_bandwidth_allocation.c | 10 +++-------
> 1 file changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/soundwire/generic_bandwidth_allocation.c b/drivers/soundwire/generic_bandwidth_allocation.c
> index 325c475b6a66d..31162f2b56381 100644
> --- a/drivers/soundwire/generic_bandwidth_allocation.c
> +++ b/drivers/soundwire/generic_bandwidth_allocation.c
> @@ -139,20 +139,16 @@ static void _sdw_compute_port_params(struct sdw_bus *bus,
> {
> struct sdw_master_runtime *m_rt;
> int hstop = bus->params.col - 1;
> - int block_offset, port_bo, i;
> + int port_bo, i;
>
> /* Run loop for all groups to compute transport parameters */
> for (i = 0; i < count; i++) {
> port_bo = 1;
> - block_offset = 1;
>
> list_for_each_entry(m_rt, &bus->m_rt_list, bus_node) {
> - sdw_compute_master_ports(m_rt, &params[i],
> - port_bo, hstop);
> + sdw_compute_master_ports(m_rt, &params[i], port_bo, hstop);
>
> - block_offset += m_rt->ch_count *
> - m_rt->stream->params.bps;
> - port_bo = block_offset;
> + port_bo += m_rt->ch_count * m_rt->stream->params.bps;
> }
>
> hstop = hstop - params[i].hwidth;

\
 
 \ /
  Last update: 2023-06-01 18:54    [W:0.051 / U:1.324 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site