Messages in this thread | | | From | "Sverdlin, Alexander" <> | Subject | Re: [PATCH] net: dsa: lan9303: allow vid != 0 in port_fdb_{add|del} methods | Date | Wed, 31 May 2023 15:20:19 +0000 |
| |
Hi Vladimir,
thank you for quick review!
On Wed, 2023-05-31 at 18:16 +0300, Vladimir Oltean wrote: > > LAN9303 doesn't associate FDB (ALR) entries with VLANs, it has just > > one > > global Address Logic Resolution table [1]. > > > > Ignore VID in port_fdb_{add|del} methods, go on with the global > > table. This > > is the same semantics as hellcreek or RZ/N1 implement. > > > > Visible symptoms: > > LAN9303_MDIO 5b050000.ethernet-1:00: port 2 failed to delete > > 00:xx:xx:xx:xx:cf vid 1 from fdb: -2 > > LAN9303_MDIO 5b050000.ethernet-1:00: port 2 failed to add > > 00:xx:xx:xx:xx:cf vid 1 to fdb: -95 > > > > [1] https://ww1.microchip.com/downloads/en/DeviceDoc/00002308A.pdf > > > > Fixes: 0620427ea0d6 ("net: dsa: lan9303: Add fdb/mdb manipulation") > > Signed-off-by: Alexander Sverdlin <alexander.sverdlin@siemens.com> > > --- > > Thanks for taking a look. Although it would probably be safer to add: > > Fixes: 2fd186501b1c ("net: dsa: be louder when a non-legacy FDB > operation fails") > > since I'm not sure it has a reason to be backported beyond that.
Well, it's not only about visible errors, but the driver also refused to install the FDB entries, so it's change in behaviour, not only cosmetics.
> Anyway: > > Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
-- Alexander Sverdlin Siemens AG www.siemens.com
| |