Messages in this thread | | | From | Doug Anderson <> | Date | Wed, 31 May 2023 07:22:49 -0700 | Subject | Re: [PATCH] drm/msm/a6xx: fix uninitialised lock in init error path |
| |
Hi,
On Wed, May 31, 2023 at 1:00 AM Johan Hovold <johan+linaro@kernel.org> wrote: > > A recent commit started taking the GMU lock in the GPU destroy path, > which on GPU initialisation failure is called before the GMU and its > lock have been initialised. > > Make sure that the GMU has been initialised before taking the lock in > a6xx_destroy() and drop the now redundant check from a6xx_gmu_remove(). > > Fixes: 4cd15a3e8b36 ("drm/msm/a6xx: Make GPU destroy a bit safer") > Cc: stable@vger.kernel.org # 6.3 > Cc: Douglas Anderson <dianders@chromium.org> > Signed-off-by: Johan Hovold <johan+linaro@kernel.org> > --- > drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 3 --- > drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 9 ++++++--- > 2 files changed, 6 insertions(+), 6 deletions(-)
I think Dmitry already posted a patch 1.5 months ago to fix this.
https://lore.kernel.org/r/20230410165908.3094626-1-dmitry.baryshkov@linaro.org
Can you confirm that works for you?
-Doug
| |