Messages in this thread | | | Date | Wed, 31 May 2023 17:55:45 -0700 | Subject | Re: [PATCH v4 1/2] remoteproc: Introduce traces for remoteproc events | From | Gokul Krishna Krishnakumar <> |
| |
On 5/31/2023 2:51 PM, Trilok Soni wrote: > On 5/31/2023 2:28 PM, Gokul krishna Krishnakumar wrote: >> Adding Traces for the following remoteproc events: >> rproc_subdev_event, >> rproc_interrupt_event, >> rproc_load_event, >> rproc_start_event, >> rproc_stop_event >> >> Signed-off-by: Gokul krishna Krishnakumar <quic_gokukris@quicinc.com> >> --- >> drivers/remoteproc/Kconfig | 5 + >> drivers/remoteproc/Makefile | 1 + >> drivers/remoteproc/remoteproc_tracepoints.c | 13 ++ >> include/trace/events/remoteproc_tracepoints.h | 129 ++++++++++++++++++ >> 4 files changed, 148 insertions(+) >> create mode 100644 drivers/remoteproc/remoteproc_tracepoints.c >> create mode 100644 include/trace/events/remoteproc_tracepoints.h >> >> diff --git a/drivers/remoteproc/Kconfig b/drivers/remoteproc/Kconfig >> index a850e9f486dd..2ef4f527f1c1 100644 >> --- a/drivers/remoteproc/Kconfig >> +++ b/drivers/remoteproc/Kconfig >> @@ -365,6 +365,11 @@ config XLNX_R5_REMOTEPROC >> It's safe to say N if not interested in using RPU r5f cores. >> +config REMOTEPROC_TRACEPOINTS >> + bool "Support for Remote Processor subsystem traces" >> + help >> + Say y to add traces to the remoteproc events. > > More information here please. What information these traces provide? How > they can be useful to developers? More text will always be helpful. > Say y to add traces to remoteproc events of interest such as the start/stop/crash events in a remote-processor and also sub-device stop/start events and there errors. These traces can be useful while debugging errors with subsystem restart and draw an estimate on how long each event takes to run.
> ---Trilok Soni
How does this look. Thanks, Gokul
| |