Messages in this thread | ![/](/images/icornerl.gif) | | Date | Mon, 29 May 2023 10:12:13 +0200 | From | Miquel Raynal <> | Subject | Re: [PATCH net-next v1 1/1] ieee802154: ca8210: Remove stray gpiod_unexport() call |
| |
Hi Andy,
andriy.shevchenko@linux.intel.com wrote on Sun, 28 May 2023 17:09:38 +0300:
> There is no gpiod_export() and gpiod_unexport() looks pretty much stray. > The gpiod_export() and gpiod_unexport() shouldn't be used in the code, > GPIO sysfs is deprecated. That said, simply drop the stray call. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Any reason not to consider a backport into stable kernels? Cc: stable + Fixes would certainly be welcome in this case?
> --- > drivers/net/ieee802154/ca8210.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/ieee802154/ca8210.c b/drivers/net/ieee802154/ca8210.c > index a2d242034220..f9b10e84de06 100644 > --- a/drivers/net/ieee802154/ca8210.c > +++ b/drivers/net/ieee802154/ca8210.c > @@ -2855,7 +2855,6 @@ static int ca8210_interrupt_init(struct spi_device *spi) > ); > if (ret) { > dev_crit(&spi->dev, "request_irq %d failed\n", pdata->irq_id); > - gpiod_unexport(gpio_to_desc(pdata->gpio_irq)); > gpio_free(pdata->gpio_irq); > } >
Thanks, Miquèl
| ![\](/images/icornerr.gif) |