lkml.org 
[lkml]   [2023]   [May]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    Subject[PATCH v5 19/34] perf evsel: Compute is_hybrid from PMU being core
    From
    Short-cut when has_hybrid is false, otherwise return if the evsel's
    PMU is core. Add a comment for the some what surprising no PMU cases
    of hardware and legacy cache events.

    Signed-off-by: Ian Rogers <irogers@google.com>
    Reviewed-by: Kan Liang <kan.liang@linux.intel.com>
    ---
    tools/perf/util/evsel.c | 12 ++++++++++--
    tools/perf/util/python.c | 5 +++++
    2 files changed, 15 insertions(+), 2 deletions(-)

    diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
    index 1df8f967d2eb..1c6e22e3f345 100644
    --- a/tools/perf/util/evsel.c
    +++ b/tools/perf/util/evsel.c
    @@ -46,8 +46,8 @@
    #include "memswap.h"
    #include "util.h"
    #include "util/hashmap.h"
    -#include "pmu-hybrid.h"
    #include "off_cpu.h"
    +#include "pmu.h"
    #include "../perf-sys.h"
    #include "util/parse-branch-options.h"
    #include "util/bpf-filter.h"
    @@ -3132,9 +3132,17 @@ void evsel__zero_per_pkg(struct evsel *evsel)
    }
    }

    +/**
    + * evsel__is_hybrid - does the evsel have a known PMU that is hybrid. Note, this
    + * will be false on hybrid systems for hardware and legacy
    + * cache events.
    + */
    bool evsel__is_hybrid(const struct evsel *evsel)
    {
    - return evsel->pmu_name && perf_pmu__is_hybrid(evsel->pmu_name);
    + if (!perf_pmu__has_hybrid())
    + return false;
    +
    + return evsel->core.is_pmu_core;
    }

    struct evsel *evsel__leader(const struct evsel *evsel)
    diff --git a/tools/perf/util/python.c b/tools/perf/util/python.c
    index 3c1f4c979c9e..b27b27086422 100644
    --- a/tools/perf/util/python.c
    +++ b/tools/perf/util/python.c
    @@ -102,6 +102,11 @@ int perf_pmu__scan_file(struct perf_pmu *pmu, const char *name, const char *fmt,
    return EOF;
    }

    +bool perf_pmu__has_hybrid(void)
    +{
    + return false;
    +}
    +
    bool evsel__is_aux_event(const struct evsel *evsel __maybe_unused)
    {
    return false;
    --
    2.41.0.rc0.172.g3f132b7071-goog
    \
     
     \ /
      Last update: 2023-05-27 09:26    [W:3.427 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site