lkml.org 
[lkml]   [2023]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 0/3] lib/string_helpers et al.: Change return value of strreplace()
On Thu, Mar 23, 2023 at 02:37:01PM +0200, Andy Shevchenko wrote:
> It's more convenient to have strreplace() to return the pointer to
> the string itself. This will help users to make their code better.
>
> The patch 1 kills the only user of the returned value of strreplace(),
> Patch 2 converts the return value of strreplace(). And patch 3 shows
> how it may be useful. That said, the series can be routed via fs tree,
> with or without the last patch.

Since there are no comments, who can apply this (patches 1 and 2)?
Greg, are you fine with the kobject change?

> In v2:
> - removed not anymore used variable (LKP)
> - added tag (Jan)
> - fixed wording (Kees)
> - actually return the pointer to the string itself
>
> Andy Shevchenko (3):
> jbd2: Avoid printing outside the boundary of the buffer
> lib/string_helpers: Change returned value of the strreplace()
> kobject: Use return value of strreplace()
>
> fs/jbd2/journal.c | 6 ++----
> include/linux/string.h | 2 +-
> lib/kobject.c | 3 +--
> lib/string_helpers.c | 12 ++++++++----
> 4 files changed, 12 insertions(+), 11 deletions(-)

--
With Best Regards,
Andy Shevchenko


\
 
 \ /
  Last update: 2023-04-05 15:35    [W:0.106 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site