Messages in this thread | ![/](/images/icornerl.gif) | | Date | Thu, 9 Mar 2023 16:04:27 +0200 | From | Andy Shevchenko <> | Subject | Re: [PATCH] sh: mach-x3proto: Add missing #include <linux/gpio/driver.h> |
| |
On Thu, Mar 09, 2023 at 02:52:55PM +0100, Geert Uytterhoeven wrote: > shx3_defconfig: > > arch/sh/boards/mach-x3proto/setup.c: In function ‘x3proto_devices_setup’: > arch/sh/boards/mach-x3proto/setup.c:246:62: error: invalid use of undefined type ‘struct gpio_chip’ > 246 | baseboard_buttons[i].gpio = x3proto_gpio_chip.base + i; > | ^ > > Reported-by: Linux Kernel Functional Testing <lkft@linaro.org> > Link: https://lore.kernel.org/r/CA+G9fYs7suzGsEDK40G0pzxXyR1o2V4Pn-oy1owTsTWRVEVHog@mail.gmail.com > Fixes: 21d9526d13b5467b ("gpiolib: Make the legacy <linux/gpio.h> consumer-only") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Thank you!
...
> #include <linux/gpio.h> > +#include <linux/gpio/driver.h>
Do we still need the legacy header?
-- With Best Regards, Andy Shevchenko
| ![\](/images/icornerr.gif) |