Messages in this thread | ![/](/images/icornerl.gif) | | From | Eric Dumazet <> | Date | Thu, 9 Mar 2023 14:37:50 +0100 | Subject | Re: [PATCH] tcp: tcp_make_synack() can be called from process context |
| |
On Wed, Mar 8, 2023 at 8:07 PM Breno Leitao <leitao@debian.org> wrote: > > tcp_rtx_synack() now could be called in process context as explained in > 0a375c822497 ("tcp: tcp_rtx_synack() can be called from process > context"). > > tcp_rtx_synack() might call tcp_make_synack(), which will touch per-CPU > variables with preemption enabled. This causes the following BUG: > > > Avoid calling __TCP_INC_STATS() with will touch per-cpu variables. Use > TCP_INC_STATS() which is safe to be called from context switch. > > Fixes: 8336886f786f ("tcp: TCP Fast Open Server - support TFO listeners") > Signed-off-by: Breno Leitao <leitao@debian.org> >
This looks good to me, thanks !
Reviewed-by: Eric Dumazet <edumazet@google.com>
| ![\](/images/icornerr.gif) |