Messages in this thread | | | Date | Thu, 9 Mar 2023 07:19:37 +0100 | Subject | Re: [PATCH 1/2] memory: tegra: remove MODULE_LICENSE in non-modules | From | Krzysztof Kozlowski <> |
| |
On 08/03/2023 21:21, Nick Alcock wrote: > Since commit 8b41fc4454e3 ("kbuild: create modules.builtin without > Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations > are used to identify modules. As a consequence, uses of the macro > in non-modules will cause modprobe to misidentify their containing > object file as a module when it is not (false positives), and modprobe > might succeed rather than failing with a suitable error message. > > So remove it in the files in this commit, none of which can be built as > modules. > > Signed-off-by: Nick Alcock <nick.alcock@oracle.com> > Suggested-by: Luis Chamberlain <mcgrof@kernel.org> > Cc: Luis Chamberlain <mcgrof@kernel.org> > Cc: linux-modules@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com> > Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Cc: Thierry Reding <thierry.reding@gmail.com> > Cc: Jonathan Hunter <jonathanh@nvidia.com> > Cc: linux-tegra@vger.kernel.org > --- > drivers/memory/tegra/mc.c | 1 - > drivers/memory/tegra/tegra186-emc.c | 1 - > 2 files changed, 2 deletions(-) > > checkpatch-clean and fused together now.
This is v2, not v1. Version the patches, always.
Best regards, Krzysztof
| |