Messages in this thread | | | Date | Thu, 9 Mar 2023 11:42:42 +0100 | Subject | Re: [PATCH v4] ASoC: cs35l41: Steam Deck Shared boost properties quirk | From | Krzysztof Kozlowski <> |
| |
On 09/03/2023 11:41, Lucas Tanure wrote: > Add support for Steam Deck bios old properties. If a Steam deck didn't > upgrade the BIOS, the driver should be able to handle the previous > properties for shared boost types. > > Signed-off-by: Lucas Tanure <lucas.tanure@collabora.com> > Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com> > --- > Changes since V3: > - Fixed missing space in if statement > - Fix the build issue, as dependency patches are already merged > > Changes since V2: > - sent the wrong patch with missing fixed lines > Changes since V1: > - else in same line as { > --- > sound/soc/codecs/cs35l41.c | 12 +++++++++--- > 1 file changed, 9 insertions(+), 3 deletions(-) > > diff --git a/sound/soc/codecs/cs35l41.c b/sound/soc/codecs/cs35l41.c > index 1624510d09c0..2803ff0f0003 100644 > --- a/sound/soc/codecs/cs35l41.c > +++ b/sound/soc/codecs/cs35l41.c > @@ -1022,9 +1022,15 @@ static int cs35l41_handle_pdata(struct device *dev, struct cs35l41_hw_cfg *hw_cf > unsigned int val; > int ret; > > - ret = device_property_read_u32(dev, "cirrus,boost-type", &val); > - if (ret >= 0) > - hw_cfg->bst_type = val; > + if (device_property_read_bool(dev, "cirrus,shared-boost-active")) {
You are now changing ABI and adding undocumented properties.
NAK.
Best regards, Krzysztof
| |